chore: additional cleanup of graal nativeimage dependency#4289
chore: additional cleanup of graal nativeimage dependency#4289
Conversation
product-auto-label
bot
added
size: xs
Summary of ChangesHello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a minor cleanup within the project's dependency configuration. By removing a redundant version specification for the GraalVM native image dependency, the change aims to simplify the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request provides a small but useful cleanup in the google-cloud-spanner/pom.xml file. By removing the explicit version for the org.graalvm.sdk:nativeimage dependency, the project now relies on the version defined in the parent POM's dependencyManagement. This is a good practice as it centralizes dependency version management, ensuring consistency and simplifying future updates. The change is correct and improves the project's maintainability.
1 participant
Realized that sdk-platform-java-config is already handling the dependencyManagement of the graal-sdk dependency through java-shared-config so we don't actually need to explicitly specify the maven property here. Let's rely on that instead to make the versions consistent across all repos: https://github.com/googleapis/java-shared-config/blob/9749349a1b427a38b6241ff55621e5fe982a0a60/native-image-shared-config/pom.xml#L69-L82